Ensure autoloader is loaded in globally installed Rector

[PhilETaylor]

Fixes rectorphp/rector#6903

When running a globally installed Rector, autoloading of the projects vendors is not happening

This PR changes that

To replicate the problem

git clone git@github.com:MGatner/rector-error.git
cd rector-error
composer install 
composer global install rector/rector
rector process -vv

Before this PR:

 [ERROR] Could not process "src/MyException.php" file, due to:
         "System error: "PHPStan\BetterReflection\Reflection\ReflectionClass
         "CodeIgniter\Exceptions\ExceptionInterface" could not be found in the
         located source"
         Run Rector with "--debug" option and post the report here:
         https://github.com/rectorphp/rector/issues/new". On line: 26

After this PR

Tagging @MGatner

[PhilETaylor]

Seems that the unit tests dont like me :-( But this fix does work...

[MGatner]

Nice find!

[samsonasik]

@PhilETaylor I rebased your branch

[samsonasik]

@TomasVotruba it seems there is error in CI that unrelated to it:

Run vendor/bin/easy-ci validate-file-length packages rules src tests

Error: ] Class "Symplify\EasyCI\ValueObject\Option" not found       

even happen on automated PR #1682

[samsonasik]

@TomasVotruba it seems Symplify\EasyCI\ValueObject is now scoped, and the generated namespace is:

namespace EasyCI20220116\Symplify\EasyCI\ValueObject;

https://github.com/symplify/easy-ci/blob/a21fa9ea29812dbcaaa2f53b430f874cd0e54112/src/ValueObject/Option.php#L4

It resolved by temporary pin symplify/easy-ci to 10.0.9 70953ba

[samsonasik]

Thank you @PhilETaylor

[samsonasik]

@PhilETaylor it somehow make e2e error on rector/rector, ref https://github.com/rectorphp/rector/runs/4829814122?check_suite_focus=true

I will check if it related to it.

[samsonasik]

@PhilETaylor it seems indeed cause error on e2e, revert it seems solve it, the possible solution possibly mention in the documentation about it.

[PhilETaylor]

Strange that the error is a PHP syntax error though, seems unrelated. In bed now but will dig further tomorrow

[MGatner]

I'm actually surprised that this was the approved way to load the project autoloader to being with:

 $this->loadIfExistsAndNotLoadedYet(__DIR__ . '/../../../autoload.php');

Given that Rector could be run from theoretically anywhere starting from __DIR__ seems dangerous. That could easily include some random unrelated vendor autoload by accident.

Surely there is some cleaner way to identify "project root", or "folder containing composer.json"?

[PhilETaylor]

The test seem to also be loading from a non standard location involving ../../bin/rector

Run ../../bin/rector process --dry-run --ansi

[samsonasik]

@MGatner that's trade off for using it globally as far as I know.
@PhilETaylor that's seems fine as pointed to path, not symlink global as far as I know.

I created PR #1685 to revert it with additional doc for using it globally (while not recommended) while we wait if there is possible solution for it.

[MGatner]

it with additional doc for using it globally (while not recommended)

I am with Sebastian Bergmann on static analysis tools not being included as project dependencies. It introduces unnecessary extra files and the opportunity for collisions. Rector does an amazing job of running separate from the project code - why restrict external execution? It seems like with all its project knowledge the executable ought to be able to locate autoload.php no matter where it is called from.