Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DowngradePhp74] Do not remove non-null default value on nullable on DowngradeTypedPropertyRector #1687

Merged
merged 4 commits into from
Jan 16, 2022
Merged

[DowngradePhp74] Do not remove non-null default value on nullable on DowngradeTypedPropertyRector #1687

merged 4 commits into from
Jan 16, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik changed the title [DowngradePhp74] Do not remove default value on DowngradeTypedPropertyRector [DowngradePhp74] Do not remove default value on nullable on DowngradeTypedPropertyRector Jan 16, 2022
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

/cc @iNem0o

@samsonasik samsonasik changed the title [DowngradePhp74] Do not remove default value on nullable on DowngradeTypedPropertyRector [DowngradePhp74] Do not remove non-null default value on nullable on DowngradeTypedPropertyRector Jan 16, 2022
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit ca696bc into main Jan 16, 2022
@TomasVotruba TomasVotruba deleted the do-not-remove-default-value-downgrade-typed branch January 16, 2022 20:06
@TomasVotruba
Copy link
Member

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @TomasVotruba