[CodeQuality][EarlyReturn] Handle SimplifyIfElseToTernaryRector + ChangeIfElseValueAssignToEarlyReturnRector

[samsonasik]

Given the following code:

final class UseOnReturnAfterIfElseAssign
{
    public static function classToArray($data, $primaryKey = null, string $dateFormat = 'datetime'): array
    {
        if (method_exists($data, 'toRawArray')) {
            $properties = $data->toRawArray();
        } else {
            $properties = (array) $data;
        }

        return $properties;
    }
}

It currently produce:

-        if (method_exists($data, 'toRawArray')) {
-            $properties = $data->toRawArray();
-        } else {
-            $properties = (array) $data;
-        }
-
-        return $properties;
+        $properties = method_exists($data, 'toRawArray') ? $data->toRawArray() : (array) $data;

which return is removed, which should be kept.

This PR try to Fixes rectorphp/rector#6955

[samsonasik]

Fixed 🎉

[samsonasik]

/cc @MGatner

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[samsonasik]

I am merging it ;)

[TomasVotruba]

👍