[Php80] Handle AnnotationToAttributeRector + ClassPropertyAssignToConstructorPromotionRector

[samsonasik]

Given the following code:

use OpenApi\Annotations as OA;

class TestResponse
{
    /**
     * @OA\Property(
     *     type="array",
     *     @OA\Items(ref=@Model(type=TestItem::class))
     * )
     */
    public array $items;

    public function __construct(array $items = [])
    {
        $this->items = $items;
    }
}

It currently produce:

-    /**
-     * @OA\Property(
-     *     type="array",
-     *     @OA\Items(ref=@Model(type=TestItem::class))
-     * )
-     */
-    public array $items;
-
-    public function __construct(array $items = [])
+    public function __construct(public array $items = [])
     {
-        $this->items = $items;
     }

which the annotation should not removed. Applied rules:

Rector\Php80\Rector\Class_\AnnotationToAttributeRector
Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector

This PR try to fixes it.

Closes #1702
Fixes rectorphp/rector#6949

[samsonasik]

Fixed 🎉

[samsonasik]

It seems cause error in test for @var:

 1) Rector\Tests\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector\ClassPropertyAssignToConstructorPromotionRectorTest::test with data set #6 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
rules-tests/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector/Fixture/typed_with_var_type.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 class TypeWithVarType
 {
-    public function __construct(private SomeTypedPropertyClass $someTypedPropertyClass)
+    public function __construct(
+        /**
+         * @var SomeTypedPropertyClass
+         */
+        private SomeTypedPropertyClass $someTypedPropertyClass
+    )

[samsonasik]

Fixed 🎉

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[TomasVotruba]

👍

[berezuev]

Thank you, @samsonasik

[bendavies]

this desn't seem to work i'm afraid. i'm using only ClassPropertyAssignToConstructorPromotionRector and annotations are still removed:

<?php

declare(strict_types=1);

use Symfony\Component\Serializer\Annotation\SerializedName;

class Address
{
    /**
     * @var string[]
     * @SerializedName("owsy/derived-facts")
     */
    private array $derivedFacts;

    public function __construct(
        array $derivedFacts = [],
    ) {
        $this->derivedFacts = $derivedFacts;
    }
}

becomes:

<?php

declare(strict_types=1);

use Symfony\Component\Serializer\Annotation\SerializedName;

class Address
{
    public function __construct(
        private array $derivedFacts = []
    )
    {
    }
}

[samsonasik]

@bendavies I can't reproduce, ref https://getrector.org/demo/1ec880a6-0fbe-6808-aca7-534e7c93c383

Please provide failing test case for it, thanks.

[bendavies]

@samsonasik apologies, the issue is when used with AUTO_IMPORT_NAMES:
https://getrector.org/demo/1ec880cf-40cb-697c-8793-8bad936652d9

[bendavies]

@samsonasik also, in your example the @var string[] should not be removed, as this is used by static analysis tools, and by symfony serializer if the @var is an array of objects.

[samsonasik]

@bendavies on that case, @var should be changed to @param on moving to parameter doc, I will try look into it.

[bendavies]

thankyou!