Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Allow unused private property on Doctrine and JMS Serializable attribute on RemoveUnusedPrivatePropertyRector #1718

Merged
merged 6 commits into from
Jan 24, 2022
Merged

[DeadCode] Allow unused private property on Doctrine and JMS Serializable attribute on RemoveUnusedPrivatePropertyRector #1718

merged 6 commits into from
Jan 24, 2022

Conversation

samsonasik
Copy link
Member

The existing functionality is for Annotation, this PR implements the @todo for readonly usage only on Attribute as well.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit e414c51 into main Jan 24, 2022
@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba deleted the allow-attribute-doctrine-readonly branch January 24, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @TomasVotruba @actions-user