[DowngradePhp72] Add DowngradeJsonDecodeNullAssociativeArgRector

[samsonasik]

Currect rector/rector dev-main on php 7.1 got broken build as nette/utils: 3.2.7 has code

$value = json_decode($json, null, 512, $flags | JSON_BIGINT_AS_STRING);

which make invalid on php 7.1, ref https://3v4l.org/qisBB#v7.1.33

This PR add DowngradeJsonDecodeNullAssociativeArgRector to make it false or cast to (bool) when not bool type.

Fixes rectorphp/rector#6967

[samsonasik]

It seems make unnecessary cast when already a false value when used on downgrade combined with DowngradeAttributeToAnnotationRector:

➜  rector-src git:(downgrade-json-decode-null) bin/rector process vendor/nette/utils/src/Utils/Json.php --config build/config/config-downgrade.php --dry-run --clear-cache
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
1 file with changes
===================

1) vendor/nette/utils/src/Utils/Json.php:52

    ---------- begin diff ----------
@@ @@
         */
        public static function decode(string $json, int $flags = 0)
        {
-               $value = json_decode($json, null, 512, $flags | JSON_BIGINT_AS_STRING);
+               $value = json_decode($json, (bool) false, 512, $flags | JSON_BIGINT_AS_STRING);
                if ($error = json_last_error()) {
                        throw new JsonException(json_last_error_msg(), $error);
                }
    ----------- end diff -----------

Applied rules:
 * DowngradeJsonDecodeNullAssociativeArgRector
 * DowngradeAttributeToAnnotationRector (https://php.watch/articles/php-attributes#syntax)


                                                                                                                        
 [OK] 1 file would have changed (dry-run) by Rector                                                                     
                                                                                                                        

[samsonasik]

Resolved with check original node 7eec01f

➜  rector-src git:(downgrade-json-decode-null) bin/rector process vendor/nette/utils/src/Utils/Json.php --config build/config/config-downgrade.php --dry-run
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
1 file with changes
===================

1) vendor/nette/utils/src/Utils/Json.php:52

    ---------- begin diff ----------
@@ @@
         */
        public static function decode(string $json, int $flags = 0)
        {
-               $value = json_decode($json, null, 512, $flags | JSON_BIGINT_AS_STRING);
+               $value = json_decode($json, false, 512, $flags | JSON_BIGINT_AS_STRING);
                if ($error = json_last_error()) {
                        throw new JsonException(json_last_error_msg(), $error);
                }
    ----------- end diff -----------

Applied rules:
 * DowngradeJsonDecodeNullAssociativeArgRector


                                                                                                                        
 [OK] 1 file would have changed (dry-run) by Rector                                                                     
                                                                                                                        

[samsonasik]

The correct way to use created by rule attribute e9f89ce, solved 🎉

Let's give it a try

[TomasVotruba]

Thank you 👍

[samsonasik]

It seems got different error now:

PHP Fatal error:  Uncaught TypeError: Return value of RectorPrefix20220125\Symplify\ComposerJsonManipulator\FileSystem\JsonFileManager::loadFromFilePath() must be of the type array, object returned in /home/runner/work/rector/rector/vendor/symplify/composer-json-manipulator/src/FileSystem/JsonFileManager.php:57

it possibly on casting (bool), when not a bool, should be negated of bool instead of direct bool. I will create new PR for it.