Incorrect behavior of FinalizePublicClassConstantRector #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Failing Test for FinalizePublicClassConstantRector Based on https://getrector.org/demo/1ec7f537-6973-6358-8246-11db50a94ec6
samsonasik
reviewed
Jan 28, 2022
.../Php81/Rector/ClassConst/FinalizePublicClassConstantRector/Fixture/class_inheritance.php.inc
Show resolved
Hide resolved
samsonasik
reviewed
Jan 28, 2022
.../Php81/Rector/ClassConst/FinalizePublicClassConstantRector/Fixture/class_inheritance.php.inc
Show resolved
Hide resolved
…tRector/Fixture/class_inheritance.php.inc Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
|
@trandbert37 I cherry-picked your commit at PR #1739 |
samsonasik
added a commit
that referenced
this pull request
Jan 28, 2022
…s children on FinalizePublicClassConstantRector (#1739) * Add failing test fixture for FinalizePublicClassConstantRector # Failing Test for FinalizePublicClassConstantRector Based on https://getrector.org/demo/1ec7f537-6973-6358-8246-11db50a94ec6 * Rename parent_class.php.inc to class_inheritance.php.inc * Update rules-tests/Php81/Rector/ClassConst/FinalizePublicClassConstantRector/Fixture/class_inheritance.php.inc Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com> * Closes #1738 * final touch: clean up * plural fix * Update rules/Php81/Rector/ClassConst/FinalizePublicClassConstantRector.php Co-authored-by: Tomas Votruba <tomas.vot@gmail.com> Co-authored-by: Alexandre Bertrand <trandbert37@users.noreply.github.com> Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to cover rectorphp/rector#6973