-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHPStan] Run PHPStan rich parser in tests to know the types + process code with tolerant parses on 1st run #1790
Conversation
5aad6bc
to
f62f1d5
Compare
56a129d
to
f364011
Compare
… default to let PHPStan know the types
398d238
to
95b5090
Compare
@TomasVotruba it seems cause error on downgrade process |
I see 👍 |
I'm exploring it and there is infinite loop. The file it fail on is: bin/rector p vendor/clue/ndjson-react/src/Decoder.php -c build/config/config-downgrade.php -n --clear-cache --debug |
I tried rollback
|
That only hides the bug. There is infinite loop with if condition. This is the reproducer: vendor/bin/phpunit rules-tests/DowngradePhp72/Rector/FuncCall/DowngradeJsonDecodeNullAssociativeArgRector/DowngradeJsonDecodeNullAssociativeArgRectorTest.php --filter test#3 |
I can't reproduce it:
and for already transformed, there is already test for it: |
Mirror to fix in PHPStan phpstan/phpstan-src@433511a
Ref rectorphp/rector#6970