Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpDocInfo] Fixes Partial value update got duplicated on DoctrineAnnotationTagValueNode change #1862

Merged
merged 26 commits into from
May 27, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

It seems happen because before @Route, there is SpacelessPhpDocTagNode

     * @Since("6.4.0.1")

which a annotation class use Shopware\Core\Framework\Routing\Annotation\Since;, so the duplication happen when there is multiple annotation class, changed after 1 annotation class, so it possibly cause parent -> child duplication.

@samsonasik samsonasik force-pushed the fixing-partial-update-docblock branch 2 times, most recently from dcb17c0 to e56ff35 Compare March 8, 2022 18:26
@TomasVotruba
Copy link
Member

Just checking, is this still valid? What is a blocker here to move it forward?

@samsonasik
Copy link
Member Author

@TomasVotruba it is, it somehow duplicated when 2 SpacelessPhpDocTagNode exists, when next is changed

@samsonasik samsonasik force-pushed the fixing-partial-update-docblock branch from ed4c96c to b4eed3c Compare May 26, 2022 11:29
@samsonasik samsonasik force-pushed the fixing-partial-update-docblock branch from 096f480 to 1b20397 Compare May 26, 2022 18:36
@samsonasik samsonasik marked this pull request as ready for review May 26, 2022 19:31
@samsonasik
Copy link
Member Author

Finally 🎉 All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik samsonasik force-pushed the fixing-partial-update-docblock branch 2 times, most recently from a0bc784 to c90c186 Compare May 26, 2022 20:24
@samsonasik
Copy link
Member Author

it seems duplicating again when changing below DoctrineAnnotationTagValueNode:

     * @required
     * @Route("/api/_admin/reset-excluded-search-term", name="api.admin.reset-excluded-search-term", methods={"POST"})
     *

it got :

      * @Route("/api/_admin/reset-excluded-search-term", name="api.admin.reset-excluded-search-term", methods={"POST"}, defaults={})
+     * @Route("/api/_admin/reset-excluded-search-term", name="api.admin.reset-excluded-search-term", methods={"POST"})

@samsonasik samsonasik marked this pull request as draft May 26, 2022 20:35
@samsonasik
Copy link
Member Author

mark as draft again, it seems need to check against non SpacelessPhpDocTagNode too.

@samsonasik samsonasik changed the title [PhpDocInfo] Fixing Partial value update got duplicated on PhpDocInfo change [PhpDocInfo] Fixes Partial value update got duplicated on DoctrineAnnotationTagValueNode change May 27, 2022
@samsonasik samsonasik marked this pull request as ready for review May 27, 2022 02:26
@samsonasik
Copy link
Member Author

Finally Fixed 🎉🎉🎉 All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

I am merging it ;)

@samsonasik samsonasik merged commit bfff1df into main May 27, 2022
@samsonasik samsonasik deleted the fixing-partial-update-docblock branch May 27, 2022 10:41
@TomasVotruba
Copy link
Member

👍

@samsonasik
Copy link
Member Author

New downgrade error seems unrelated, symfony cache trait and test http client can be ignored from parallellint check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants