-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PhpDocInfo] Fixes Partial value update got duplicated on DoctrineAnnotationTagValueNode change #1862
Conversation
It seems happen because before
which a annotation class |
dcb17c0
to
e56ff35
Compare
Just checking, is this still valid? What is a blocker here to move it forward? |
@TomasVotruba it is, it somehow duplicated when 2 |
e56ff35
to
ed4c96c
Compare
ed4c96c
to
b4eed3c
Compare
096f480
to
1b20397
Compare
Finally 🎉 All checks have passed 🎉 @TomasVotruba it is ready for review. |
a0bc784
to
c90c186
Compare
it seems duplicating again when changing below * @required
* @Route("/api/_admin/reset-excluded-search-term", name="api.admin.reset-excluded-search-term", methods={"POST"})
* it got : * @Route("/api/_admin/reset-excluded-search-term", name="api.admin.reset-excluded-search-term", methods={"POST"}, defaults={})
+ * @Route("/api/_admin/reset-excluded-search-term", name="api.admin.reset-excluded-search-term", methods={"POST"}) |
mark as draft again, it seems need to check against non |
Finally Fixed 🎉🎉🎉 All checks have passed 🎉 @TomasVotruba it is ready for review. |
I am merging it ;) |
👍 |
New downgrade error seems unrelated, symfony cache trait and test http client can be ignored from parallellint check. |
Fixes rectorphp/rector#7020