Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove unneeded ChangedNodeAnalyzer service #1868

Merged
merged 5 commits into from
Feb 25, 2022
Merged

[Core] Remove unneeded ChangedNodeAnalyzer service #1868

merged 5 commits into from
Feb 25, 2022

Conversation

samsonasik
Copy link
Member

It seems ChangedNodeAnalyzer is no longer needed

@samsonasik
Copy link
Member Author

For only change docblock, there is already e2e test for it https://github.com/rectorphp/rector-src/tree/main/e2e/applied-rule-change-docblock

@samsonasik
Copy link
Member Author

Also remove HAS_PHP_DOC_INFO_JUST_CHANGED attribute as when Rector rule returns Node, it will show the diff + rules applied when changed on Node with line.

@samsonasik
Copy link
Member Author

I added e2e test for RemoveUselessVarTagRector to show that HAS_PHP_DOC_INFO_JUST_CHANGED no longer needed e850121

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit 961c3ae into main Feb 25, 2022
@TomasVotruba TomasVotruba deleted the remove-unneded-changed-node-analyzer branch February 25, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @TomasVotruba @actions-user