Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php81] Fix property with attribute inlined on ReadOnlyPropertyRector #1869

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

samsonasik
Copy link
Member

Given the following code:

    #[Serializer\Since(Option::SINCE_20211124)]
    private string $name;

It currently produce inlined readonly:

-    private readonly string $name;
+    #[Serializer\Since(Option::SINCE_20211124)]private readonly string $name;

which should be on next line of attribute. This PR try to fix it.

Fixes rectorphp/rector#7021

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @reypm

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thanks 👍

@TomasVotruba TomasVotruba merged commit 4dee58b into main Feb 25, 2022
@TomasVotruba TomasVotruba deleted the fix-inlined-with-attribute branch February 25, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants