Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min to PHP 7.2 #1955

Merged
merged 7 commits into from
Mar 24, 2022
Merged

Bump min to PHP 7.2 #1955

merged 7 commits into from
Mar 24, 2022

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Mar 22, 2022

Closes rectorphp/rector#7068

image

Time to follow up 📈

@TomasVotruba TomasVotruba changed the title Bump min to PHP 7.2 [WIP] Bump min to PHP 7.2 Mar 22, 2022
full_build.sh Outdated Show resolved Hide resolved
@samsonasik
Copy link
Member

samsonasik commented Mar 24, 2022

@TomasVotruba DowngradeParameterTypeWidening settings at build/config/config-downgrade.php seems no longer needed as it down from php 7.2 to 7.1

$services = $containerConfigurator->services();
$services->set(DowngradeParameterTypeWideningRector::class)
->configure([
LoaderInterface::class => ['load'],
Loader::class => ['import'],
]);

@TomasVotruba
Copy link
Member Author

@samsonasik Thanks 👍 I've removed it

@samsonasik
Copy link
Member

samsonasik commented Mar 24, 2022

Phpstan 1.5.0 released https://github.com/phpstan/phpstan/releases/tag/1.5.0

I think requirement need to be updated too composer.json

"phpstan/phpstan": ^1.5.0"

in both root composer.json and target-repository

@TomasVotruba
Copy link
Member Author

@samsonasik Thanks 👍

@TomasVotruba TomasVotruba marked this pull request as ready for review March 24, 2022 20:55
@TomasVotruba TomasVotruba changed the title [WIP] Bump min to PHP 7.2 Bump min to PHP 7.2 Mar 24, 2022
@TomasVotruba TomasVotruba merged commit 278cd56 into main Mar 24, 2022
@TomasVotruba TomasVotruba deleted the tv-bump-php72 branch March 24, 2022 21:17
@TomasVotruba
Copy link
Member Author

Let's try the deploy and test the downgraded version 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants