Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodingStyle] Skip AddFalseDefaultToBoolPropertyRector on assigned in __construct #1998

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

samsonasik
Copy link
Member

Given the following code should be skipped for adding default value to property as always filled in __construct.

class SkipAssignInConstruct
{
    /**
     * @var bool
     */
    private $property;

    public function __construct(bool $property)
    {
        $this->property = $property;
    }
}

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 836d939 into main Apr 2, 2022
@TomasVotruba TomasVotruba deleted the skip-assigned-in-construct branch April 2, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants