[docs] Improve first-time contributors docs #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
samsonasik
reviewed
Apr 12, 2022
|
|
||
| ```bash | ||
| composer check-platform-reqs | ||
| git clone git@github.com:rectorphp/rector-src.git |
There was a problem hiding this comment.
should clone from fork:
Suggested change
| git clone git@github.com:rectorphp/rector-src.git | |
| git clone git@github.com:your-username/rector-src.git |
There was a problem hiding this comment.
Just noticed... will update
There was a problem hiding this comment.
Actually, it's not always rector/rector-src and rector-src.git. It can be rector/rector-nette or some other sub-package of the monorepo.
And then the path to running individual tests is also different.
There was a problem hiding this comment.
How would you phrase it?
~90 % contributions goes here, the rest to vendor packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for feedback @xpavp03