-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scoped] Clean up bootstrap.php to load scoper autoload #2255
Conversation
All checks have passed 🎉 @TomasVotruba I think it is ready. |
I don’t understand how can this work if there’s no autoload section in the target repository composer.json. How do I autoload Rector classes for example when running unit tests of custom Rectors or when analysing custom Rectors with PHPStan? |
@ondrejmirtes how about the # ensure only loaded once
require_once __DIR__ . '/vendor/autoload.php';
require_once __DIR__ . '/vendor/scoper-autoload.php'; |
@ondrejmirtes I rolled back |
Ok, with above change, and running scoper script and it cause error in my local dev:
|
It seems broke the scoper when I run the full_build.sh, I am closing for now. @ondrejmirtes feel free to create separate PR if you have better solution. To verify locally for updated code, you can run the following script:
Update I am closing for now ;) |
@TomasVotruba @ondrejmirtes this PR cleanup bootstrap.php from scoped version of rector. In
rector.php
, I modified the sort autoload as follow:prefixed autoload is included in bootstrap.php