[DeadCode] Ensure no stmts check on RemovePhpVersionIdCheckRector

[samsonasik]

ref https://github.com/rectorphp/rector-src/pull/2259/files#r867380537

[samsonasik]

Fixed 🎉

[samsonasik]

@TomasVotruba return $if is needed to avoid "applied rules" not shown in the list, ref

rector-src/src/Rector/AbstractRector.php

Lines 207 to 210 in 2dd8c6b

	// nothing to change → continue
	if ($node === null) {
	return null;
	}

which it only shows when it has node or array of stmts returns:

rector-src/src/Rector/AbstractRector.php

Lines 220 to 222 in 2dd8c6b

	/** @var Node $originalNode */
	$rectorWithLineChange = new RectorWithLineChange($this::class, $originalNode->getLine());
	$this->file->addRectorClassWithLine($rectorWithLineChange);

[TomasVotruba]

The changed should be included for removed nodes too. The AbstractRector should be updated instead.

[samsonasik]

Ok, I created PR #2261 for it.

[samsonasik]

@TomasVotruba that seems not doable by only move up the RectorWithLineChange as the information of Node removed is against original node, which if it returns null, it fallback to clone $node, which the information is for object before refactor, ref

rector-src/src/Rector/AbstractRector.php

Line 192 in fb8260c

$originalNode = $node->getAttribute(AttributeKey::ORIGINAL_NODE) ?? clone $node;

it also cause errors in other e2e tests by move it up, ref PR #2261 (comment)

[TomasVotruba]

Thanks 👏