[DX] Add StmtsAwareInterface to catch node by type #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-stmts-aware-interface
branch
7 times, most recently
from
5aa2f28
to
bdeb97c
Compare
staabm
reviewed
May 8, 2022
|
I thought of that and it's just a marker interface, with no logic nor methods, so should be ok. The |
|
Turned differently: Might it lead to problems when running rector in tandem with something bundling PHPParser (e.g. phpstan) and autoloading will not load the patched PHPParser classes shipped with rector, but different ones..? Do we need to make sure, rector is working with the patched PHPParser version? |
|
The rule would have to specifically require it. I'll update the patch paths and we can test it out 👍 |
TomasVotruba
force-pushed
the
tv-stmts-aware-interface
branch
from
bdeb97c
to
089c55c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@todo consider proposing directly to php-parser to ease the node traversing
@todo move to to allow in Rector extensions https://github.com/rectorphp/vendor-patches