Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parallel] Fix --debug not working in parallel #2307

Merged
merged 4 commits into from
May 13, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented May 13, 2022

Before

bin/rector process src/Config/  --clear-cache --debug

                                                                                                                        
 [OK] Rector is done!                                                                                                                                                                                                                    

After

bin/rector process src/Config/  --clear-cache --debug

src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[file] src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[rule] Rector\DeadCode\Rector\Node\RemoveNonExistingVarAnnotationRector

[file] src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[rule] Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector

[file] src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[rule] Rector\DeadCode\Rector\Node\RemoveNonExistingVarAnnotationRector

[file] src/Config/Loader/ConfigureCallMergingLoaderFactory.php
[rule] Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector

ref rectorphp/rector#7164 (reply in thread)

@samsonasik samsonasik force-pushed the fix-debug-not-working-in-parallel branch from c06fbe9 to cbec756 Compare May 13, 2022 10:18
@samsonasik
Copy link
Member Author

It seems make test error:



There were 2 errors:

1) Rector\Tests\Parallel\Command\WorkerCommandLineFactoryTest::test with data set #0 (array('process', array('src')), ''/usr/bin/php8.1' 'main_scrip...o-ansi')
Symfony\Component\Console\Exception\InvalidArgumentException: The "debug" option does not exist.

while registering to AbstractProcessCommand make it not displayed.

@samsonasik samsonasik marked this pull request as draft May 13, 2022 10:47
@samsonasik samsonasik marked this pull request as ready for review May 13, 2022 11:48
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

I am merging it ;)

@samsonasik samsonasik merged commit 26d2589 into main May 13, 2022
@samsonasik samsonasik deleted the fix-debug-not-working-in-parallel branch May 13, 2022 16:10
@TomasVotruba
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants