Use rector downgrade php #2582
Use rector downgrade php #2582
Conversation
|
It seems got error: 0s
Run bin/rector process rules --ansi
[ERROR] File path
"/home/runner/work/rector-src/rector-src/vendor/rector/rector-downgrade
-php/config/config.php" was not found while creating
"Symplify\SmartFileSystem\SmartFileInfo" object. |
|
Possibly this is missing in Should be added to rector-downgrade-php An type as well: https://github.com/rectorphp/rector-symfony/blob/c6abe8d19e2ebde7365e94eb8bb268b87935bd9d/composer.json#L3 |
|
Let's try |
| - | ||
| run: composer require rector/rector-downgrade-php:dev-main --no-update | ||
| if: github.repository != 'rectorphp/rector-downgrade-php' |
There was a problem hiding this comment.
this is temporary as require rector/rector-src in previous step seems using --no-update
This reverts commit 2257be6.
|
@TomasVotruba I am not sure about error on packages-tests workflow for There were 671 errors:
1) Rector\Tests\DowngradePhp53\Rector\Dir\DirConstToFileConstRector\DirConstToFileConstRectorTest::test with data set #0 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Symfony\Component\DependencyInjection\Exception\RuntimeException: Cannot autowire service "Rector\DeadCode\Comparator\Parameter\ParameterDefaultsComparator": argument "$defaultParameterValueResolver" of method "__construct()" references class "Rector\DowngradePhp80\Reflection\DefaultParameterValueResolver" but no such service exists.it seems overlapped with previous command for https://github.com/rectorphp/rector-src/runs/7091105254?check_suite_focus=true#step:8:27 |
|
tweaked with check to not require rector/rector-src temporary on package tests for rectorphp/rector-downgrade-php ,it seems due to overlapped service 1323080 |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Let's roll 🎊💪 |
| CoalesceAnalyzer::class, | ||
| NamespacedNameDecorator::class, | ||
| NamedVariableFactory::class, | ||
| BinaryOpTreeRootLocator::class, |
There was a problem hiding this comment.
Are any of these used only in the downgrade set?
If so, those should be moved there, even for price of namespace rename
|
For ref, this PR makes use of this package: https://github.com/rectorphp/rector-downgrade-php |
|
Thanks to this decoupling, we got ~21 % speed improvement on CI run for rules-test 🎉 ⚡ Before - 3:43
After - 3:04
|
No description provided.