Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Remove the composer upgrade as unused to narrow focus back to PHP #2865

Merged
merged 6 commits into from Aug 31, 2022

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Aug 31, 2022

When we added this almost 1,5 year ago, it seems like a good idea - https://getrector.org/blog/2021/01/25/introducing-composer-json-rector-rules One one side, upgrading PHP code and composer goes together.


Yet, as time went by, few design and DX problems revealed themselves:

  • the composer.json domain is completelly different than PHP - code styling, conventions and format preserving printing
  • the project usually upgrade one package at a time - imagine upgrading Symfony 2.8 and Rector forcing you to jump your composer.json config together, even if you don't want to
  • for that reasons, it's not used by any vendor packages in core even after 18 months :)
  • the way would be to have a standalone project that focused on composer.json only, if needed

For these reasons, we remove this feature from Rector.

We'll keep focusing on PHP to make PHP upgrades more reliable and fun to use 🙂

@TomasVotruba TomasVotruba changed the title tv less file processor [DX] Remove the composer upgrade as unused to narrow focus back to PHP Aug 31, 2022
@TomasVotruba TomasVotruba force-pushed the tv-less-file-processor branch 3 times, most recently from f2a176d to 869319d Compare August 31, 2022 08:42
@lulco
Copy link
Contributor

lulco commented Sep 20, 2022

For me this is huge step back :( is there a way how can I add it back in my rectors?

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Sep 20, 2022

As a contributors of this feature, I understood.

If you need it, you can implement this as your own package/tools that handles the composer.json changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants