Skip to content

Skip MakeTypedPropertyNullableIfCheckedRector for constructor assigment. #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 1 commit into from
Nov 18, 2022
Merged

Skip MakeTypedPropertyNullableIfCheckedRector for constructor assigment. #3074

TomasVotruba merged 1 commit into from
Nov 18, 2022

Conversation

@Wohlie
Copy link
Contributor

@Wohlie Wohlie commented Nov 17, 2022 •
edited by samsonasik
Loading

@Wohlie Wohlie requested a review from TomasVotruba as a code owner November 17, 2022 21:06
@TomasVotruba TomasVotruba merged commit b5ddb02 into rectorphp:main Nov 18, 2022
@TomasVotruba
Copy link
Member

TomasVotruba commented Nov 18, 2022

Thank you 👍

@Wohlie Wohlie deleted the skip-make-typed-property-nullable-if-checked-rector-on-constructor-assignment branch November 18, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of MakeTypedPropertyNullableIfCheckedRector Incorrect behavior of MakeTypedPropertyNullableIfCheckedRector

3 participants

@Wohlie @TomasVotruba @samsonasik