Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Move update node with php doc info changed into PhpDocInfo::markAsChanged() #3089

Conversation

samsonasik
Copy link
Member

The DocBlockUpdater::updateRefactoredNodeWithPhpDocInfo() was introduced at PR:

for ensure refresh refactored node with PhpDocInfo before refresh Scope, which was unable to use existing DocBlockUpdater::updateNodeWithPhpDocInfo().

After various try, it seems it can be moved to PhpDocInfo::markAsChanged() so it only apply when PhpDocInfo::markAsChanged() called.

@samsonasik
Copy link
Member Author

It seems cause error on AttributeCompatibleAnnotationRectorTest, closing for now.

@samsonasik samsonasik closed this Nov 23, 2022
@samsonasik samsonasik deleted the move-refresh-docblock-info-on-phpdoc-info-mark-as-changed branch November 23, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants