Skip to content

[CodeQuality] Handle BooleanNot on SimplifyEmptyCheckOnEmptyArrayRector #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 2 commits into from
Dec 7, 2022
Merged

[CodeQuality] Handle BooleanNot on SimplifyEmptyCheckOnEmptyArrayRector #3170

TomasVotruba merged 2 commits into from
Dec 7, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 7, 2022

The BooleanNot on:

! empty($values)

it currently produce:

-! empty($values)
+!($values === [])

which will be readable with direct not identical:

-! empty($values)
+$values !== []

@samsonasik
Copy link
Member Author

samsonasik commented Dec 7, 2022

implemented 🎉

@samsonasik
Copy link
Member Author

samsonasik commented Dec 7, 2022

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 7, 2022

Thank you 👏

@TomasVotruba TomasVotruba merged commit f8ad265 into main Dec 7, 2022
@TomasVotruba TomasVotruba deleted the handle-boolean-not-simplify-empty-check branch December 7, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samsonasik @TomasVotruba