Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php82] Add Utf8DecodeEncodeToMbConvertEncodingRector #3195

Merged
merged 9 commits into from
Dec 14, 2022

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 14, 2022

This is to fix rectorphp/rector#7658

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

It seems ut8_encode -> mb_convert_encoding can be applied as well with pass 2 and 3 arguments https://3v4l.org/WkmFR

@samsonasik samsonasik marked this pull request as draft December 14, 2022 06:02
@samsonasik samsonasik changed the title [Php82] Add Utf8DecodeToMbConvertEncodingRector [Php82] Add Utf8DecodeEncodeToMbConvertEncodingRector Dec 14, 2022
@samsonasik samsonasik marked this pull request as ready for review December 14, 2022 06:14
@samsonasik
Copy link
Member Author

implemented 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik samsonasik closed this Dec 14, 2022
@samsonasik samsonasik reopened this Dec 14, 2022
@TomasVotruba TomasVotruba merged commit c21cafa into main Dec 14, 2022
@TomasVotruba TomasVotruba deleted the add-utf-8-decode branch December 14, 2022 10:03
@TomasVotruba
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants