[CodeQuality][TypeDeclaration] Handle default value from constructor removed on InlineConstructorDefaultToPropertyRector+TypedPropertyFromStrictConstructorRector

rules/TypeDeclaration/AlreadyAssignDetector/ConstructorAssignDetector.php

@@ -14,8 +14,10 @@
 use PHPStan\Type\ObjectType;
 use Rector\Core\NodeAnalyzer\PropertyFetchAnalyzer;
 use Rector\Core\ValueObject\MethodName;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
+use Rector\PostRector\Collector\NodesToRemoveCollector;
 use Rector\TypeDeclaration\Matcher\PropertyAssignMatcher;
 use Rector\TypeDeclaration\NodeAnalyzer\AutowiredClassMethodOrPropertyAnalyzer;
 
@@ -31,7 +33,8 @@ public function __construct(
         private readonly PropertyAssignMatcher $propertyAssignMatcher,
         private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser,
         private readonly AutowiredClassMethodOrPropertyAnalyzer $autowiredClassMethodOrPropertyAnalyzer,
-        private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer
+        private readonly PropertyFetchAnalyzer $propertyFetchAnalyzer,
+        private readonly NodesToRemoveCollector $nodesToRemoveCollector
     ) {
     }
 
@@ -64,6 +67,11 @@ public function isPropertyAssigned(ClassLike $classLike, string $propertyName):
                     return null;
                 }
 
+                $parentNode = $assign->getAttribute(AttributeKey::PARENT_NODE);
+                if ($parentNode instanceof Expression && $this->nodesToRemoveCollector->isNodeRemoved($parentNode)) {
+                    return null;
+                }
+
                 $isAssignedInConstructor = true;
 
                 return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;

tests/Issues/InlineTypedFromConstructorDefaultValue/Fixture/fixture.php.inc

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\InlineTypedFromConstructorDefaultValue\Fixture;
+
+final class Fixture
+{
+    private $url;
+
+    public function __construct()
+    {
+        $this->url = 'https://website.tld';
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\InlineTypedFromConstructorDefaultValue\Fixture;
+
+final class Fixture
+{
+    private string $url = 'https://website.tld';
+
+    public function __construct()
+    {
+    }
+}
+
+?>

tests/Issues/InlineTypedFromConstructorDefaultValue/InlineTypedFromConstructorDefaultValueTest.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\InlineTypedFromConstructorDefaultValue;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class InlineTypedFromConstructorDefaultValueTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    /**
+     * @return Iterator<array<string>>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/InlineTypedFromConstructorDefaultValue/config/configured_rule.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Rector\Config\RectorConfig;
+use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([
+        InlineConstructorDefaultToPropertyRector::class,
+        TypedPropertyFromStrictConstructorRector::class,
+    ]);
+};