Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Remove 73 unused public methods 🎄 #3245

Merged
merged 7 commits into from
Dec 23, 2022
Merged

[cleanup] Remove 73 unused public methods 🎄 #3245

merged 7 commits into from
Dec 23, 2022

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Dec 23, 2022 •
edited

How can we detect unused public methods?

With PHPStan :)

https://tomasvotruba.com/blog/can-phpstan-find-dead-public-methods/

@TomasVotruba TomasVotruba changed the title update package Make use of unused public, type coverage and cognitive complexity split PHPStan rules 🎉 Dec 23, 2022
@TomasVotruba TomasVotruba force-pushed the tv-new-phpstan-packages branch 2 times, most recently from 0dc2209 to 9fa6d80 Compare December 23, 2022 15:50
@TomasVotruba TomasVotruba changed the title Make use of unused public, type coverage and cognitive complexity split PHPStan rules 🎉 [cleanup] Remove unused public methods Dec 23, 2022
@TomasVotruba TomasVotruba force-pushed the tv-new-phpstan-packages branch 7 times, most recently from 3c7bb98 to 83d6fc1 Compare December 23, 2022 16:39
@TomasVotruba TomasVotruba force-pushed the tv-new-phpstan-packages branch 2 times, most recently from 85f9864 to 6aa6a7a Compare December 23, 2022 16:48
@TomasVotruba TomasVotruba changed the title [cleanup] Remove unused public methods [cleanup] Remove 73 unused public methods Dec 23, 2022
@TomasVotruba TomasVotruba merged commit bfa1891 into main Dec 23, 2022
@TomasVotruba TomasVotruba deleted the tv-new-phpstan-packages branch December 23, 2022 17:06
@TomasVotruba TomasVotruba changed the title [cleanup] Remove 73 unused public methods [cleanup] Remove 73 unused public methods 🎄🎄🎄 Dec 23, 2022
@TomasVotruba TomasVotruba changed the title [cleanup] Remove 73 unused public methods 🎄🎄🎄 [cleanup] Remove 73 unused public methods 🎄 Dec 23, 2022
@alexey-m-ukolov alexey-m-ukolov mentioned this pull request Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@TomasVotruba