-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] handle multiple classes with anonymous class on MultipleClassFileToPsr4ClassesRector file removed #3253
Conversation
736537f
to
02b1998
Compare
…leToPsr4ClassesRector
02b1998
to
ecf8024
Compare
It reproduced with e2e test https://github.com/rectorphp/rector-src/actions/runs/3774459745/jobs/6416564084 |
Fixed 🎉 with verify anonymous class via |
All checks have passed 🎉 @TomasVotruba I think it is ready 🎉 |
I also add handling for match and no match class with file 1b65a04 , the diffing will need improvement, but that will require different PR :) |
-class ClassMatchFileName implements SomeInterface | ||
-{ | ||
-} | ||
- | ||
-interface SomeInterface | ||
-{ | ||
-} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff require improvement as it actually changed to:
+class ClassMatchFileName implements \App\SomeInterface
+{
+}
when not using --dry-run
, but that will need to be in separate PR for improvement :)
Finally 🎉 🎉 🎉 All checks have passed 🎉 @TomasVotruba I think it is ready. |
Given the following code:
On configuration:
It cause crash :
Ref https://getrector.org/demo/d6b959e8-3007-4c95-bc92-eb0421236a4c
It only reproducible with e2e test due to on
WorkerRunner
usage:rector-src/packages/Parallel/WorkerRunner.php
Line 113 in bce8153
Fixes rectorphp/rector#7695