Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Printer][EarlyReturn] Enable InlineHTML on RemoveAlwaysElseRector #3387

Merged
merged 10 commits into from
Feb 16, 2023

Conversation

samsonasik
Copy link
Member

Previously, we skipped the RemoveAlwaysElseRector with InlineHTML exists in Else_ part at PR:

which skipped due to previous Stmt just removed so it has different parent Node with original Node. This PR enable it to allow InlineHTML on Else_ part which just removed.

/cc @kkmuffme

@samsonasik samsonasik changed the title [Printer] Enable InlineHTML on RemoveAlwaysElseRector [Printer][EarlyReturn] Enable InlineHTML on RemoveAlwaysElseRector Feb 16, 2023
@samsonasik samsonasik marked this pull request as draft February 16, 2023 17:15
@samsonasik samsonasik marked this pull request as ready for review February 16, 2023 17:26
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@samsonasik
Copy link
Member Author

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit d8aa22b into main Feb 16, 2023
@samsonasik samsonasik deleted the enable-inlinehtml-remove-always-else branch February 16, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants