Alternative Rector workflow on check repo before steps run #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Mar 2, 2023
| - | ||
| if: github.event.pull_request.head.repo.full_name != github.repository | ||
| uses: actions/checkout@v3 | ||
| - run: echo "run on ${{ github.event.pull_request.head.repo.full_name }}" |
There was a problem hiding this comment.
@TomasVotruba this is to verify the repo name to verify and it show:
Run echo "run on rectorphp/rector-src"
run on rectorphp/rector-src
see https://github.com/rectorphp/rector-src/actions/runs/4316268191/jobs/7531815857#step:3:1
There was a problem hiding this comment.
The pull_request.head seems goes to forks repo name
while github.repository goes to target repo name, so I changed to github.event.pull_request.head.repo.full_name
|
All checks have passed 🎉 @TomasVotruba let's give it a try? @jackbentley you need to rebase your PR #3430 again to verify if it keep works after this merged. |
|
Let's try it out 🙏 |
|
@TomasVotruba it doesn't work, it now show pending on PR from fork, see #3430 (comment) |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
* Alternative Rector workflow on check repo before steps run * show display repo name to check * check full name * try add unused property * [ci-review] Rector Rectify * update templaet --------- Co-authored-by: GitHub Action <actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba this is alternative PR of:
which move the check on before steps instead of before strategy.
Closes #3439