Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache on successful file processing #3604

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

yguedidi
Copy link
Contributor

Should closes rectorphp/rector#7770

caching still works, same performance

@yguedidi yguedidi marked this pull request as draft April 10, 2023 16:06
@yguedidi yguedidi marked this pull request as ready for review April 10, 2023 16:29
@TomasVotruba
Copy link
Member

Thank you

@TomasVotruba TomasVotruba merged commit 4c56874 into rectorphp:main Apr 11, 2023
36 checks passed
@yguedidi yguedidi deleted the fix-rectorphp-rector-7770 branch April 11, 2023 07:19
@samsonasik
Copy link
Member

@yguedidi it seems I need to revert it, as it cause double --dry-run no longer work
Screen Shot 2023-04-11 at 15 17 59

@samsonasik
Copy link
Member

Reverting it at #3607

samsonasik added a commit that referenced this pull request Apr 11, 2023
samsonasik pushed a commit that referenced this pull request May 8, 2023
samsonasik added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants