Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php55] Add StaticToSelfOnFinalClassRector #3629

Merged
merged 12 commits into from
Apr 19, 2023
Merged

[Php55] Add StaticToSelfOnFinalClassRector #3629

merged 12 commits into from
Apr 19, 2023

Conversation

samsonasik
Copy link
Member

To make static::class to self::class on final class.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thanks!

Could you update rule name to include "final"? So its clear its only for this context.

@samsonasik samsonasik changed the title [Php55] Add StaticToSelfRector [Php55] Add StaticToSelfOnFinalClassRector Apr 19, 2023
@samsonasik
Copy link
Member Author

@TomasVotruba I renamed to StaticToSelfOnFinalClassRector 5d9655b

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba TomasVotruba merged commit 581fba0 into main Apr 19, 2023
@TomasVotruba TomasVotruba deleted the static-to-self branch April 19, 2023 07:08
@TomasVotruba
Copy link
Member

Thanks 👍😊

samsonasik added a commit that referenced this pull request May 8, 2023
* [Php55] Add StaticToSelfRector

* skip dynamic

* skip on trait

* skip in abstract class

* [ci-review] Rector Rectify

* skip on constant call

* generate docs

* register to config set php 5.5

* skip already self

* rename to StaticToSelfOnFinalClassRector

* [ci-review] Rector Rectify

* fix namespace

---------

Co-authored-by: GitHub Action <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants