[NodeTypeResolver] Handle crash after next exit() on no namespaced code after removal next attribute #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
crash-after-exit
branch
from
f5fd6af
to
873d911
Compare
|
Fixed 🎉 /cc @PhilETaylor |
|
Confirmed this PR works - thanks. 🎉 Before
After manually applying change to packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php only
|
|
@PhilETaylor thank you for verify, PHPStan notice seems unrelated, I will fix that in separate PR. |
|
Restart build. |
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removal of
nextattribute, on no namespaced code, the stmts collected viaFileWithoutNamespaceNodeTraverserwhich seems late detect theUnreachableStatementNodenext stmt handling cause crash.This PR try to fix rectorphp/rector#7972