Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Php80] Fix add default nullable type on ClassPropertyAssignToConstructorPromotionRector #4091

Merged
merged 19 commits into from
Jun 6, 2023
Merged

[Php80] Fix add default nullable type on ClassPropertyAssignToConstructorPromotionRector #4091

merged 19 commits into from
Jun 6, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik marked this pull request as draft June 5, 2023 23:54
@samsonasik samsonasik mentioned this pull request Jun 5, 2023
Merged
@samsonasik samsonasik marked this pull request as ready for review June 6, 2023 00:01
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

I think we need more general solution, eg param string default false, transformed to param bool|string.

@samsonasik
Copy link
Member Author

I added string default false fixture e5d9862

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thank you 👏

@TomasVotruba TomasVotruba merged commit ff21394 into main Jun 6, 2023
44 checks passed
@TomasVotruba TomasVotruba deleted the add-default-nullable-type branch June 6, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @TomasVotruba