[Core] Always reset stopTraversal to false on next Rector visit #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/PhpParser/NodeTraverser/RectorNodeTraverser.php
|
@TomasVotruba by this, verify just reprinted node in |
|
Just reprinted node check seems still needed |
|
Phpdoc info update on each after refactor() seems no longer needed e6a4100 |
|
All checks have passed 🎉 @TomasVotruba let's give it a try 👍 |
|
@TomasVotruba it seems has 1 error, not syntax error, but https://github.com/rectorphp/rector-src/actions/runs/5235899119/jobs/9453066468#step:24:11 on vendor/symfony/console/Command/Command.php, I will immediate revert with try another solution. I think |
|
Reverting at #4183 |
samsonasik
added a commit
that referenced
this pull request
Jun 11, 2023
* Remove PARENT_NODE from BetterStandardPrinter * [ci-review] Rector Rectify * Revert "[Core] Always reset stopTraversal to false on next Rector visit (#4182)" (#4183) This reverts commit bb609b2. --------- Co-authored-by: GitHub Action <actions@github.com> Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref rectorphp/rector-downgrade-php#108 (review)