Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Skip RemoveUnusedNonEmptyArrayBeforeForeachRector on array param has default null #433

Merged
merged 14 commits into from
Jul 14, 2021
Merged

[DeadCode] Skip RemoveUnusedNonEmptyArrayBeforeForeachRector on array param has default null #433

merged 14 commits into from
Jul 14, 2021

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik
Copy link
Member Author

Fixed 🎉 Also move nullable check and has default null value check to ParamAnalyzer, applied to other rules.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 4f2d2d1 into main Jul 14, 2021
@TomasVotruba TomasVotruba deleted the skip-param-default-null branch July 14, 2021 07:13
@TomasVotruba
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@samsonasik @TomasVotruba @actions-user