Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs double import #478

Merged
merged 1 commit into from Jul 21, 2021
Merged

Fix docs double import #478

merged 1 commit into from Jul 21, 2021

Conversation

TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-fix-double-import branch 6 times, most recently from 304b519 to 91b6fc4 Compare July 21, 2021 13:25
@TomasVotruba TomasVotruba changed the title debug double import Fix docs double import Jul 21, 2021
@TomasVotruba TomasVotruba force-pushed the tv-fix-double-import branch 2 times, most recently from e65cb58 to 6cb9845 Compare July 21, 2021 13:28
@TomasVotruba
Copy link
Member Author

TomasVotruba commented Jul 21, 2021

The broken use case in typo3 is violating tag name also for values: https://github.com/sabbelasichon/typo3-rector/blob/main/src/Rector/v9/v0/IgnoreValidationAnnotationRector.php
It must be fixed to tag + values separately.

...

1 hours later

...

Actually there was a bug in Rector for aliased imports: #480, but the doc node tag should be fixed too in Typo3

@TomasVotruba TomasVotruba merged commit 24a32df into main Jul 21, 2021
@TomasVotruba TomasVotruba deleted the tv-fix-double-import branch July 21, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant