Faster AddReturnTypeDeclarationBasedOnParentClassMethodRector #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 17, 2023
|
|
||
| use Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationBasedOnParentClassMethodRector\Source\SomeClassWithoutReturnType; | ||
|
|
||
| class MyClass extends SomeClassWithoutReturnType |
There was a problem hiding this comment.
this test was asserting that no changes happen -> moved it to a "skip fixture"
staabm
commented
Aug 17, 2023
| return null; | ||
| } | ||
|
|
||
| $parentClassMethod = $this->astResolver->resolveClassMethodFromMethodReflection($parentMethodReflection); |
There was a problem hiding this comment.
astResolver->resolveClassMethodFromMethodReflection is super in-efficient because it needs to parse the whole file into nodes
samsonasik
reviewed
Aug 17, 2023
staabm
changed the title
samsonasik
approved these changes
Aug 17, 2023
|
@TomasVotruba for some reason, this PR and #4805 is not mentioned in the latest release notes |
|
@staabm That's because I try to mention changes that might be interesting to the end user to avoid creating clutter news with all the merges. Tiny fixes and speed improvements depens on the impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running
AddReturnTypeDeclarationBasedOnParentClassMethodRectoron a class which misses returnt types, and extends a class with several thousands lines of code (e.g. TCPDF) takes 45-50 seconds before this PR and 5 seconds after this PR.before this PR it took 768 MB of memory, after the PR it takes 256 MB
-> ~10 times faster
-> requires only 30% memory of previous approach