Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddReturnTypeDeclarationBasedOnParentClassMethodRector: don't trust phpdoc types #4810

Merged
merged 3 commits into from Aug 17, 2023
Merged

AddReturnTypeDeclarationBasedOnParentClassMethodRector: don't trust phpdoc types #4810

merged 3 commits into from Aug 17, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 17, 2023 •
edited

fixes the typo in #4809 so the test fails as I expected ;-)

@staabm staabm changed the title Fix typo in AddReturnTypeDeclarationBasedOnParentClassMethodRector test AddReturnTypeDeclarationBasedOnParentClassMethodRector: don't trust phpdoc types Aug 17, 2023
@staabm staabm marked this pull request as ready for review August 17, 2023 15:14
@TomasVotruba TomasVotruba merged commit 5363a67 into rectorphp:main Aug 17, 2023
43 checks passed
@TomasVotruba
Copy link
Member

Thanks 👍

@staabm staabm deleted the fix2 branch August 17, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@staabm @TomasVotruba @samsonasik