Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Narrow tests to single job, as now takes 20 s 🚀 #4827

Merged
merged 4 commits into from Aug 21, 2023
Merged

[CI] Narrow tests to single job, as now takes 20 s 🚀 #4827

merged 4 commits into from Aug 21, 2023

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Aug 21, 2023 •
edited

@TomasVotruba TomasVotruba changed the title [ci] try narrow rules tests [ci] Narrow rules tests to single job Aug 21, 2023
@TomasVotruba TomasVotruba changed the title [ci] Narrow rules tests to single job [CI] Narrow rules tests to single job Aug 21, 2023
@TomasVotruba TomasVotruba changed the title [CI] Narrow rules tests to single job [CI] Narrow rules tests to single job, as now takes < 300 ms Aug 21, 2023
@TomasVotruba TomasVotruba changed the title [CI] Narrow rules tests to single job, as now takes < 300 ms [CI] Narrow rules tests to single job, as now takes 9,5 s Aug 21, 2023
@TomasVotruba TomasVotruba changed the title [CI] Narrow rules tests to single job, as now takes 9,5 s [CI] Narrow rules tests to single job, as now takes 9,5 s 🚀 Aug 21, 2023
staabm
staabm reviewed Aug 21, 2023
View reviewed changes
phpunit.xml
@@ -15,27 +15,6 @@
<directory>packages-tests</directory>
<directory>utils-tests</directory>
</testsuite>

<!-- divide the rules-tests roughly in 3 equal sized groups -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the one person who introduced this test-suite splitting, I am really happy that the suite is so much faster now, so we don't need the splitting.

great job!

@TomasVotruba TomasVotruba changed the title [CI] Narrow rules tests to single job, as now takes 9,5 s 🚀 [CI] Narrow tests to single job, as now takes 9,5 s 🚀 Aug 21, 2023
@TomasVotruba TomasVotruba changed the title [CI] Narrow tests to single job, as now takes 9,5 s 🚀 [CI] Narrow tests to single job, as now takes 30 s 🚀 Aug 21, 2023
@TomasVotruba TomasVotruba changed the title [CI] Narrow tests to single job, as now takes 30 s 🚀 [CI] Narrow tests to single job, as now takes 20 s 🚀 Aug 21, 2023
@samsonasik samsonasik mentioned this pull request Aug 21, 2023
Merged
@TomasVotruba TomasVotruba merged commit c5fab3a into main Aug 21, 2023
38 checks passed
@TomasVotruba TomasVotruba deleted the tv-narrow-tests branch August 21, 2023 13:35
@TomasVotruba TomasVotruba mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm left review comments

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@TomasVotruba @staabm @samsonasik