[Config] Add merging of rules configuration, call configure() just once #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
… from previous calls
TomasVotruba
commented
Aug 23, 2023
Comment on lines
+180
to
185
| if ($isBound) { | ||
| return; | ||
| } | ||
|
|
||
| $this->singleton($rectorClass); | ||
| $this->tagRectorService($rectorClass); |
There was a problem hiding this comment.
Without this check, the same Rector rule would be registered twice. That could lead to unexpected changes and waste of resources.
TomasVotruba
commented
Aug 23, 2023
| ): void { | ||
| $ruleConfiguration = $this->ruleConfigurations[$rectorClass]; | ||
| $configurableRector->configure($ruleConfiguration); | ||
| }); |
There was a problem hiding this comment.
The configure() is now called exactly once with the full configuration.
We might check for the configuration override and have custom property to add this after resolving too. In case of non-configurable rules, but it might be too defensive. Let's see how it performs :)
|
Thanks for the solution @samsonasik 👍 |
|
@TomasVotruba this cause a bug in rector-doctrine, see I will remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8150
Closes #4831