Revert "use NewOptimizedDirectorySourceLocator" #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Aug 24, 2023
Comment on lines
+610
to
+614
| # todo: to be updated to use NewOptimizedDirectorySourceLocator later | ||
| # currently changing to NewOptimizedDirectorySourceLocator cause error, @see https://github.com/rectorphp/rector-src/actions/runs/5965685296/job/16183665877#step:10:19 | ||
| - | ||
| message: '#Instantiation of deprecated class PHPStan\\Reflection\\BetterReflection\\SourceLocator\\OptimizedDirectorySourceLocator#' | ||
| path: packages/NodeTypeResolver/Reflection/BetterReflection/SourceLocatorProvider/DynamicSourceLocatorProvider.php |
There was a problem hiding this comment.
this new NewOptimizedDirectorySourceLocator is a todo later as currently cause error when applied, noted above.
There was a problem hiding this comment.
@TomasVotruba ok, it seems the error stil exists, so the issue is not because of NewOptimizedDirectorySourceLocator
https://github.com/rectorphp/rector-src/actions/runs/5965825544/job/16184110293#step:10:19
There was a problem hiding this comment.
@TomasVotruba let's revert the revert, I will look into the fix :)
samsonasik
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit 07e36e3.
samsonasik
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit 07e36e3.
samsonasik
added a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4844