[TypeDeclaration] skip variadic constructor param of mixed type on AddParamTypeFromPropertyTypeRector #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Aug 31, 2023
...aramTypeFromPropertyTypeRector/Fixture/skip_variadic_constructor_param_of_mixed_type.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 31, 2023
...d/AddParamTypeFromPropertyTypeRector/Fixture/variadic_constructor_param_of_explicit_type.php
Outdated
Show resolved
Hide resolved
...d/AddParamTypeFromPropertyTypeRector/Fixture/variadic_constructor_param_of_explicit_type.php
Outdated
Show resolved
Hide resolved
This reverts commit 353a75f. Taking over type of doc block would be nice. As discussed in PR: we can't rely on docblock, so skipping is the safest.
samsonasik
reviewed
Aug 31, 2023
Comment on lines
+96
to
99
| if ($param->variadic) { | ||
| continue; | ||
| } | ||
| if (! $this->paramTypeAddGuard->isLegal($param, $node)) { |
There was a problem hiding this comment.
Looks good 👍 , we can move the variadic check to $this->paramTypeAddGuard->isLegal() method if we have another use case in other rule
samsonasik
approved these changes
Aug 31, 2023
samsonasik
changed the title
|
Thank you @Celebrate-Reinhard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8168