Faster SilentVoidResolver #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 6, 2023
| @@ -44,15 +46,14 @@ public function hasExclusiveVoid(ClassMethod | Closure | Function_ $functionLike | |||
| return false; | |||
| } | |||
|
|
|||
| /** @var Return_[] $returns */ | |||
| $returns = $this->betterNodeFinder->findInstancesOfInFunctionLikeScoped($functionLike, Return_::class); | |||
There was a problem hiding this comment.
only search for the first return with a expression, instead of searching all returns
There was a problem hiding this comment.
@staabm it seems cause bug:
Ref https://getrector.com/demo/1f06cf14-382e-4161-ba39-d2061164ebab
I created PR:
for it.
There was a problem hiding this comment.
samsonasik
reviewed
Sep 6, 2023
samsonasik
approved these changes
Sep 6, 2023
|
Let's give it a try, thank you @staabm |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.