Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Naming] Remove matchesStringName() check completely from NodeNameResolver, including endsWith() method - use getName() and compare directly instead #4954

Merged
merged 5 commits into from
Sep 9, 2023
Merged

[Naming] Remove matchesStringName() check completely from NodeNameResolver, including endsWith() method - use getName() and compare directly instead #4954

merged 5 commits into from
Sep 9, 2023

Commits on Sep 9, 2023

  1. [Naming] Remove regex check completely from NodeNameResolver

    @TomasVotruba
    TomasVotruba committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    ef6614f View commit details
    Browse the repository at this point in the history

  2. rename variable to match type

    @TomasVotruba
    TomasVotruba committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    a4d9c29 View commit details
    Browse the repository at this point in the history

  3. keep underscore fixture

    @TomasVotruba
    TomasVotruba committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    6347c92 View commit details
    Browse the repository at this point in the history

  4. remove unused matchesStringName()

    @TomasVotruba
    TomasVotruba committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    f974a82 View commit details
    Browse the repository at this point in the history

  5. Remove startsWith() and endsWith(), use getName() directly and compar… 

    …e as needed
    @TomasVotruba
    TomasVotruba committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    08f3cd7 View commit details
    Browse the repository at this point in the history