[Transform] Check str_contains * before fnmatch() early on AddAllowDynamicPropertiesAttributeRector #4991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cPropertiesAttributeRector
samsonasik
changed the title
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
samsonasik
commented
Sep 11, 2023
Comment on lines
+144
to
146
| if (str_contains($transformOnNamespace, '*')) { | ||
| if (! fnmatch($transformOnNamespace, $className, FNM_NOESCAPE)) { | ||
| return true; |
There was a problem hiding this comment.
@TomasVotruba @staabm this conditions seems need to be on last resort to check because it returns true on negation early, I will create separate PR to cover too late check.
staabm
reviewed
Sep 11, 2023
| } | ||
|
|
||
| if ($this->nodeNameResolver->isStringName($className, $transformOnNamespace)) { | ||
| continue; |
There was a problem hiding this comment.
this needs to be return true ?
There was a problem hiding this comment.
hmm actually I am not sure. is this area covered by tests?
There was a problem hiding this comment.
I am going to add new fixture to cover this
There was a problem hiding this comment.
it's not, it need to be processed as exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba @staabm here based on #4980 (comment)