Narrow rule complexity, add custom PHPStan to check whole rule complexity tree and spot architecture flaws #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can't we already do the same thing with class-complexity rules? |
|
We have those. This is slightly different and checks the peaks :) |
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-file-providers
branch
2 times, most recently
from
cfea725
to
a3765f4
Compare
…rule more readable
… construcotr dependenciesů gs
TomasVotruba
force-pushed
the
tv-file-providers
branch
from
8e471ea
to
2b4bb16
Compare
TomasVotruba
force-pushed
the
tv-file-providers
branch
from
0f1578c
to
e9baa43
Compare
TomasVotruba
force-pushed
the
tv-file-providers
branch
4 times, most recently
from
e1af418
to
e0da377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.