Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQuality] Only check start from current Stmt token pos up until open parentheses on CompleteMissingIfElseBracketRector #5127

Merged
merged 3 commits into from Oct 6, 2023

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik samsonasik changed the title [CodeQuality] Only check start from current Stmt token pos below on CompleteMissingIfElseBracketRector [CodeQuality] Only check start from current Stmt token pos up until ) on CompleteMissingIfElseBracketRector Oct 6, 2023
@samsonasik samsonasik changed the title [CodeQuality] Only check start from current Stmt token pos up until ) on CompleteMissingIfElseBracketRector [CodeQuality] Only check start from current Stmt token pos up until open parentheses on CompleteMissingIfElseBracketRector Oct 6, 2023
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit af065e7 into main Oct 6, 2023
41 checks passed
@samsonasik samsonasik deleted the only-check-current-stmt branch October 6, 2023 06:11
@samsonasik
Copy link
Member Author

It seems cause invalid spacing removal, reverting to add more test later

@samsonasik
Copy link
Member Author

Reverted at #5128

I will try re-add test later to have more check usage.

samsonasik added a commit that referenced this pull request Oct 6, 2023
… until open parentheses on CompleteMissingIfElseBracketRector (#5127)" (#5128)

This reverts commit af065e7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant