Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQuality] Handle on closure, anonymous function, method call on CompleteMissingIfElseBracketRector #5135

Merged
merged 12 commits into from Oct 6, 2023

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik samsonasik marked this pull request as draft October 6, 2023 20:08
@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik samsonasik marked this pull request as ready for review October 6, 2023 20:54
@samsonasik samsonasik marked this pull request as draft October 6, 2023 21:03
@samsonasik
Copy link
Member Author

samsonasik commented Oct 6, 2023

It still cause invalid change on complex parentheses:

➜  CodeIgniter4 git:(develop) ✗ vendor/bin/rector process utils/check_tabs_in_rst.php  --clear-cache --dry-run -vvv

1 file with changes
===================

1) utils/check_tabs_in_rst.php:59

    ---------- begin diff ----------
@@ @@
             array_values($normalizedRstFilesWithTabs),
         )),
     );
-
     exit(1);
 }
    ----------- end diff -----------

Applied rules:
 * CompleteMissingIfElseBracketRector

I will check more.

@samsonasik samsonasik marked this pull request as ready for review October 6, 2023 21:44
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

@samsonasik samsonasik merged commit 22bf404 into main Oct 6, 2023
41 checks passed
@samsonasik samsonasik deleted the closure-anoy branch October 6, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant