Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeadCode] Skip indirect variable definition on RemoveNonExistingVarAnnotationRector #5152

Merged
merged 2 commits into from Oct 10, 2023
Merged

[DeadCode] Skip indirect variable definition on RemoveNonExistingVarAnnotationRector #5152

merged 2 commits into from Oct 10, 2023

Conversation

samsonasik
Copy link
Member

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @staabm

samsonasik
samsonasik commented Oct 10, 2023
View reviewed changes
...dCode/Rector/Node/RemoveNonExistingVarAnnotationRector/Fixture/skip_next_inline_html.php.inc
Comment on lines +1 to +9
<?php

/**
* @var string $value
*/

?>

<div class="<?php echo $value; ?>"></div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@staabm this also skip next InlineHTML

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 6cb63f3 into main Oct 10, 2023
41 checks passed
@samsonasik samsonasik deleted the indirect-var branch October 10, 2023 10:42
@staabm
Copy link
Contributor

staabm commented Oct 10, 2023

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samsonasik @staabm