[CodeQuality] Handle negative and positive int/float on InlineConstructorDefaultToPropertyRector

[samsonasik]

Fixes rectorphp/rector#8261

[samsonasik]

Fixed 🎉 /cc @JulianCBC

[samsonasik]

All checks have passed 🎉 @TomasVotruba let's merge it ;)

[JulianCBC]

Is this actually enough to fully handle UnaryMinus and UnaryPlus? Am I right that, for the purposes of determining whether an expression is dynamic, the unary plus and unary minus don't matter? I.e. should something like:

class Test {
    public $thing;
    public function __construct() {
        $this->thing = -CONSTANT;
    }
}

should also get moved?

[samsonasik]

Accessing constant on property default value can be dangerous that cause compile time error, see https://3v4l.org/W8Epd

I think exact int and float value is the safest :)

[JulianCBC]

I'm not disagreeing that it's the safest.

I think that something like this would cover almost all possible scenarios:

            if ($expr instanceof UnaryPlus || $expr instanceof UnaryMinus) {
                return $this->isDynamicExpr($expr->expr);
            }

[samsonasik]

I see, yes, it seems can be covered with:

             if ($expr instanceof UnaryPlus || $expr instanceof UnaryMinus) {
-                return ! $expr->expr instanceof LNumber && ! $expr->expr instanceof DNumber;
+                return $this->isDynamicExpr($expr->expr);
+            }

@JulianCBC could you create a PR improvement for it with add fixture for possible constants ? Thank you.

[JulianCBC]

Can do! PR incoming...

[JulianCBC]

Done: #5177